[Top] [All Lists]

Re: [PATCH] xfstests: v2 xfs directory unbalance assert test

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: v2 xfs directory unbalance assert test
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 17 Sep 2013 16:35:46 -0500
Cc: Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130917213409.GL19103@dastard>
References: <20130917192538.230164044@xxxxxxx> <20130917213409.GL19103@dastard>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 9/17/13 4:34 PM, Dave Chinner wrote:
> On Tue, Sep 17, 2013 at 02:25:23PM -0500, Mark Tinguely wrote:
>> This tests triggers an assert in the XFS directory unbalance code.
>> This test originally written by Brian Foster and suggestions
>> from Micheal Semon.
>> Signed-off-by: Mark Tinguely <tinguely@xxxxxxx> 
>> ---
>> v1->v2:
>>  remove clean up.
>>  remove $seqres.full before test.
>>  remove scratch mount.
>>  11g -> calculate 11g bytes.
>>  check for failing mkfs and mount.
>>  add a safer removal of the scratch files.
>>  put into auto group and "long" group so people can opt out:
>>   this test almost an hour on my test box.
> 45m is too long for the auto group. The entire auto group runs in
> 50-55 minutes on my test VMs, so doubling that for one test is not
> really a good idea.

Ok, sorry, my fault.  Fix on commit?


> The usual rule of thumb for the auto group is that the test should
> take less than 5 minutes to run. For the quick group, it should take
> less than 30-60s to run.
> If you want to make this test run in the auto group, scale it for
> stress tests via the use of LOAD_FACTOR and TIME_FACTOR, and add it
> to the stress group.
> Cheers,
> Dave.

<Prev in Thread] Current Thread [Next in Thread>