Re: [PATCH] xfstests: xfs directory unbalance assert test

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Tue, Sep 17, 2013 at 09:59:47AM -0500, Mark Tinguely wrote:
> +# Fill the filesystem.
> +FSSTRESS_ARGS="-z -s 1378390208 -fsymlink=1 -n7500000 -p4 -d $SCRATCH_MNT"
> +$FSSTRESS_PROG $FSSTRESS_ARGS >> $seqres.full 2>&1
> +
> +cd $SCRATCH_MNT >> $seqres.full 2>&1
> +sync
> +# A debug XFS may assert in the remove due to a directory bug.
> +rm -rf *

Wouldn't this be better:

sync
rm -rf $SCRATCH_MNT/*

Remember, xfstests runs as root and so having a "rm -rf *" anywhere
in a test is a disaster just waiting to happen....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx