xfs
[Top] [All Lists]

Re: [PATCH] xfstests: xfs directory unbalance assert test

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfstests: xfs directory unbalance assert test
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 18 Sep 2013 07:29:17 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130917145959.333796933@xxxxxxx>
References: <20130917145946.124195107@xxxxxxx> <20130917145959.333796933@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 17, 2013 at 09:59:47AM -0500, Mark Tinguely wrote:
> +# Fill the filesystem.
> +FSSTRESS_ARGS="-z -s 1378390208 -fsymlink=1 -n7500000 -p4 -d $SCRATCH_MNT"
> +$FSSTRESS_PROG $FSSTRESS_ARGS >> $seqres.full 2>&1
> +
> +cd $SCRATCH_MNT >> $seqres.full 2>&1
> +sync
> +# A debug XFS may assert in the remove due to a directory bug.
> +rm -rf *

Wouldn't this be better:

sync
rm -rf $SCRATCH_MNT/*

Remember, xfstests runs as root and so having a "rm -rf *" anywhere
in a test is a disaster just waiting to happen....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>