xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfstests: add d_type checking to fsstress

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfstests: add d_type checking to fsstress
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 16 Sep 2013 17:22:12 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52377E50.3040907@xxxxxxxxxx>
References: <52377E50.3040907@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/16/13 16:55, Eric Sandeen wrote:
This patch adds a "-D" switch to fsstress so that every time
we call readdir, we stat the dentry&  compare it's st_mode
to the d_type.

If -D is specified only once, it ignores DT_UNKNOWN.  If specified
twice, it considers DT_UNKNOWN to be an error.

It skips paths of "./." and "./.." so that we only look at files
newly created within the filesystem.

This could be used in an xfstest; it's noisy on a failures so
would break expected output.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

fsstress doesn't usually do validation, but it's such a handy
framework for creating a ton of random files, this seems like
an ok place to put it.  What do folks think?

I tried v5 and v4 with and without inode fields in the directory.
This looks good to me. Like the 2 levels of the test.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>