xfs
[Top] [All Lists]

Re: [PATCH 31/55 V3] libxfs: switch over to xfs_sb.c and remove xfs_moun

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 31/55 V3] libxfs: switch over to xfs_sb.c and remove xfs_mount.c
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 15 Sep 2013 13:27:18 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52307D39.6060903@xxxxxxx>
References: <1378332359-14737-1-git-send-email-david@xxxxxxxxxxxxx> <1378332359-14737-32-git-send-email-david@xxxxxxxxxxxxx> <522A1BCA.6010500@xxxxxxx> <20130906214021.GD12541@dastard> <522A4C79.1030200@xxxxxxx> <20130910010241.GZ12779@dastard> <522F289E.6070802@xxxxxxx> <20130910213249.GC19103@dastard> <52306F3E.8060409@xxxxxxx> <52307D39.6060903@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 11, 2013 at 09:24:57AM -0500, Mark Tinguely wrote:
> On 09/11/13 08:25, Mark Tinguely wrote:
> >On 09/10/13 16:32, Dave Chinner wrote:
> >
> > > libxfs: switch over to xfs_sb.c and remove xfs_mount.c
> > >
> > > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > >
> > > Now that the kernel code has split the superblock specific code out
> > > of xfs_mount.c, we don't need xfs_mount.c anymore. Copy in xfs_sb.c
> > > and remove xfs_mount.c
> > >
> > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > > ---
> >
> >Applies clean for me.
> >
> >Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>
> 
> patch 31 V2/V3 break the compilation of xfsprogs.
> 
> I get:
> ...
> 
> configure: creating ./config.status
> config.status: creating include/builddefs
> config.status: creating include/platform_defs.h
> config.status: executing libtool commands
> Building include
>     [LN]     xfs
>     [LN]     disk
> Building libxfs
>     [CC]     gen_crc32table
>     [GENERATE] crc32table.h
>     [TEST]    CRC32
> CRC_LE_BITS = 32
> crc32: tests passed, 225944 bytes in 117 usec
> crc32c: tests passed, 225944 bytes in 121 usec
> gmake[3]: *** No rule to make target `.ltdep', needed by `ltdepend'.  Stop.
> gmake[2]: *** [libxfs] Error 2
> make[1]: *** [default] Error 2
> make: *** [default] Error 2

That's a dependency build problem because the dependencies changed
and weren't rebuilt.  make distclean and start again, and the
dependencies will get rebuilt correctly.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>