xfs
[Top] [All Lists]

[PATCH] xfs_check: fix test for too-high level in v2 dir node

To: "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>
Subject: [PATCH] xfs_check: fix test for too-high level in v2 dir node
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Thu, 12 Sep 2013 16:00:23 -0500
Delivered-to: linux-xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
The test as it stands allows level == XFS_DA_NODE_MAXDEPTH (5),
but a max depth of 5 equates to level values of 0 through 4.

Level 5 would be a depth of 6.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

diff --git a/db/check.c b/db/check.c
index cbe55ba..d9e3e3f 100644
--- a/db/check.c
+++ b/db/check.c
@@ -3138,7 +3138,7 @@ process_leaf_node_dir_v2_int(
        case XFS_DA_NODE_MAGIC:
                node = iocur_top->data;
                xfs_da3_node_hdr_from_disk(&nodehdr, node);
-               if (nodehdr.level < 1 || nodehdr.level > XFS_DA_NODE_MAXDEPTH) {
+               if (nodehdr.level < 1 || nodehdr.level >= XFS_DA_NODE_MAXDEPTH) 
{
                        if (!sflag || v)
                                dbprintf(_("bad node block level %d for dir ino 
"
                                         "%lld block %d\n"),

<Prev in Thread] Current Thread [Next in Thread>