xfs
[Top] [All Lists]

Re: xfs: recovery of swap extents operations for CRC filesystems

To: Dave Chinner <dchinner@xxxxxxxxxx>
Subject: Re: xfs: recovery of swap extents operations for CRC filesystems
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 11 Sep 2013 17:44:43 -0500
Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, tinguely@xxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130911021929.GF2445@xxxxxxxxxxxxxxxxx>
References: <20130911211819.GB10527@xxxxxxxxxxxxxx> <20130911021929.GF2445@xxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/10/13 21:19, Dave Chinner wrote:
On Thu, Sep 12, 2013 at 12:18:19AM +0300, Dan Carpenter wrote:
Hello Dave Chinner,

The patch 638f44163d57: "xfs: recovery of swap extents operations for
CRC filesystems" from Aug 30, 2013, leads to the following
static checker warning: "fs/xfs/xfs_log_recover.c:2999
xlog_recover_inode_pass2()
         info: ignoring unreachable code."

fs/xfs/xfs_log_recover.c
   2992  out_release:
   2993          xfs_buf_relse(bp);
   2994  error:
   2995          if (need_free)
   2996                  kmem_free(in_f);
   2997          return XFS_ERROR(error);
                 ^^^^^^^^^^^^^^^^^^^^^^^
   2998
   2999          xfs_buf_relse(bp);
   3000          goto error;

These two added lines are unreachable.  Sometimes people add dead code
for later, so this might be intentional.  It's not clear.

It's dead code. I reworked the error handling of the function and
didn't clean up all the mess.

Mark, I'm away from my upstream dev environment until next week -
can you send a followup patch to fix this?

Cheers,

Dave.

sure. I should have caught it in review.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>