xfs
[Top] [All Lists]

Re: xfs: recovery of swap extents operations for CRC filesystems

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: xfs: recovery of swap extents operations for CRC filesystems
From: Dave Chinner <dchinner@xxxxxxxxxx>
Date: Wed, 11 Sep 2013 12:19:29 +1000
Cc: xfs@xxxxxxxxxxx, mtinguely@xxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130911211819.GB10527@xxxxxxxxxxxxxx>
References: <20130911211819.GB10527@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 12, 2013 at 12:18:19AM +0300, Dan Carpenter wrote:
> Hello Dave Chinner,
> 
> The patch 638f44163d57: "xfs: recovery of swap extents operations for
> CRC filesystems" from Aug 30, 2013, leads to the following
> static checker warning: "fs/xfs/xfs_log_recover.c:2999
> xlog_recover_inode_pass2()
>        info: ignoring unreachable code."
> 
> fs/xfs/xfs_log_recover.c
>   2992  out_release:
>   2993          xfs_buf_relse(bp);
>   2994  error:
>   2995          if (need_free)
>   2996                  kmem_free(in_f);
>   2997          return XFS_ERROR(error);
>                 ^^^^^^^^^^^^^^^^^^^^^^^
>   2998  
>   2999          xfs_buf_relse(bp);
>   3000          goto error;
> 
> These two added lines are unreachable.  Sometimes people add dead code
> for later, so this might be intentional.  It's not clear.

It's dead code. I reworked the error handling of the function and
didn't clean up all the mess.

Mark, I'm away from my upstream dev environment until next week -
can you send a followup patch to fix this?

Cheers,

Dave.
-- 
Dave Chinner
dchinner@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>