xfs
[Top] [All Lists]

re: xfs: recovery of swap extents operations for CRC filesystems

To: dchinner@xxxxxxxxxx
Subject: re: xfs: recovery of swap extents operations for CRC filesystems
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 12 Sep 2013 00:18:19 +0300
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
Hello Dave Chinner,

The patch 638f44163d57: "xfs: recovery of swap extents operations for
CRC filesystems" from Aug 30, 2013, leads to the following
static checker warning: "fs/xfs/xfs_log_recover.c:2999
xlog_recover_inode_pass2()
         info: ignoring unreachable code."

fs/xfs/xfs_log_recover.c
  2992  out_release:
  2993          xfs_buf_relse(bp);
  2994  error:
  2995          if (need_free)
  2996                  kmem_free(in_f);
  2997          return XFS_ERROR(error);
                ^^^^^^^^^^^^^^^^^^^^^^^
  2998  
  2999          xfs_buf_relse(bp);
  3000          goto error;

These two added lines are unreachable.  Sometimes people add dead code
for later, so this might be intentional.  It's not clear.

  3001  }

regards,
dan carpenter

<Prev in Thread] Current Thread [Next in Thread>