| To: | Ben Myers <bpm@xxxxxxx>, Dave Chinner <dchinner@xxxxxxxxxx> |
|---|---|
| Subject: | [patch] xfs: = vs == typo in ASSERT() |
| From: | Dan Carpenter <dan.carpenter@xxxxxxxxxx> |
| Date: | Thu, 12 Sep 2013 00:17:31 +0300 |
| Cc: | Alex Elder <elder@xxxxxxxxxx>, xfs@xxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
There is a '=' vs '==' typo so the ASSERT()s are always true.
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
Introduced in 21b5c9784b ('xfs: swap extents operations for CRC
filesystems')
diff --git a/fs/xfs/xfs_bmap_btree.c b/fs/xfs/xfs_bmap_btree.c
index 531b020..bb8de8e 100644
--- a/fs/xfs/xfs_bmap_btree.c
+++ b/fs/xfs/xfs_bmap_btree.c
@@ -957,9 +957,9 @@ xfs_bmbt_change_owner(
ASSERT(tp || buffer_list);
ASSERT(!(tp && buffer_list));
if (whichfork == XFS_DATA_FORK)
- ASSERT(ip->i_d.di_format = XFS_DINODE_FMT_BTREE);
+ ASSERT(ip->i_d.di_format == XFS_DINODE_FMT_BTREE);
else
- ASSERT(ip->i_d.di_aformat = XFS_DINODE_FMT_BTREE);
+ ASSERT(ip->i_d.di_aformat == XFS_DINODE_FMT_BTREE);
cur = xfs_bmbt_init_cursor(ip->i_mount, tp, ip, whichfork);
if (!cur)
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfstests: generic/311: add a few more test cases, Josef Bacik |
|---|---|
| Next by Date: | re: xfs: recovery of swap extents operations for CRC filesystems, Dan Carpenter |
| Previous by Thread: | [PATCH] xfstests: generic/311: add a few more test cases, Josef Bacik |
| Next by Thread: | Re: [patch] xfs: = vs == typo in ASSERT(), Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |