[Top] [All Lists]

Re: [PATCH] [RFC] xfs: increase inode cluster size for v5 filesystems

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] [RFC] xfs: increase inode cluster size for v5 filesystems
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 11 Sep 2013 09:21:59 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130909153546.GT12779@dastard>
References: <1378715664-19969-1-git-send-email-david@xxxxxxxxxxxxx> <20130909133254.GA14778@xxxxxxxxxxxxx> <20130909153546.GT12779@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 10, 2013 at 01:35:47AM +1000, Dave Chinner wrote:
> The test matrix of having to test everything on v4 and v5 is just
> nasty, especially if we are talking about prototyping code. I'd much
> prefer to bring things to v5 filesytsems where we have much lower
> exposure and risk of corruption problems, and then when we know it's
> solid because of the QA we've done on it, then we can expose the
> majority of the XFS userbase to it by bringing it back to v4
> filesystems.

I think the test matrix is a reason for not enabling this only on v5
filesystems.  Large inodes are an old and supported use case, although
probably not as heavily tested as it should.  By introducing two
different large inode cases we don't really help increasing test
coverage for a code path that is the same for v4 and v5.

That being said as long as you're still prototyping I'm not going to

<Prev in Thread] Current Thread [Next in Thread>