xfs
[Top] [All Lists]

Re: [PATCH 31/55 V3] libxfs: switch over to xfs_sb.c and remove xfs_moun

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 31/55 V3] libxfs: switch over to xfs_sb.c and remove xfs_mount.c
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Wed, 11 Sep 2013 10:11:29 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <52306F3E.8060409@xxxxxxx>
References: <1378332359-14737-1-git-send-email-david@xxxxxxxxxxxxx> <1378332359-14737-32-git-send-email-david@xxxxxxxxxxxxx> <522A1BCA.6010500@xxxxxxx> <20130906214021.GD12541@dastard> <522A4C79.1030200@xxxxxxx> <20130910010241.GZ12779@dastard> <522F289E.6070802@xxxxxxx> <20130910213249.GC19103@dastard> <52306F3E.8060409@xxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/11/13 08:25, Mark Tinguely wrote:
On 09/10/13 16:32, Dave Chinner wrote:

 > libxfs: switch over to xfs_sb.c and remove xfs_mount.c
 >
 > From: Dave Chinner <dchinner@xxxxxxxxxx>
 >
 > Now that the kernel code has split the superblock specific code out
 > of xfs_mount.c, we don't need xfs_mount.c anymore. Copy in xfs_sb.c
 > and remove xfs_mount.c
 >
 > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
 > ---

Applies clean for me.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>


Oops, on testing V2/V3 of the patch, the libxfs/xfs_mount.c was left
in these reposted patches and libxfs/xfs_sb.c was not and the reposeted
patches won't compile.

My mistake for concentrating on the header file when reviewing and not
the whole re-post.

Looks like everything is fine if using the libxfs/xfs_sb.c from the
first post.

--Mark

<Prev in Thread] Current Thread [Next in Thread>