xfs
[Top] [All Lists]

Re: [PATCH v2] xfs: check magic numbers in dir3 leaf verifier first

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfs: check magic numbers in dir3 leaf verifier first
From: Ben Myers <bpm@xxxxxxx>
Date: Mon, 9 Sep 2013 17:51:37 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130903000658.GJ12779@dastard>
References: <1378119020-31299-1-git-send-email-david@xxxxxxxxxxxxx> <20130903000658.GJ12779@dastard>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Sep 03, 2013 at 10:06:58AM +1000, Dave Chinner wrote:
> xfs: check magic numbers in dir3 leaf verifier first
> 
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Calling xfs_dir3_leaf_hdr_from_disk() in a verifier before
> validating the magic numbers in the buffer results in ASSERT
> failures due to mismatching magic numbers when a corruption occurs.
> Seeing as the verifier is supposed to catch the corruption and pass
> it back to the caller, having the verifier assert fail on error
> defeats the purpose of detecting the errors in the first place.
> 
> Check the magic numbers direct from the buffer before decoding the
> header.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cleaned up the spurious newline and applied.

<Prev in Thread] Current Thread [Next in Thread>