[Top] [All Lists]

Re: [PATCH] [RFC] xfs: increase inode cluster size for v5 filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] [RFC] xfs: increase inode cluster size for v5 filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 10 Sep 2013 01:35:47 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130909133254.GA14778@xxxxxxxxxxxxx>
References: <1378715664-19969-1-git-send-email-david@xxxxxxxxxxxxx> <20130909133254.GA14778@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Sep 09, 2013 at 06:32:54AM -0700, Christoph Hellwig wrote:
> I can't see anything v5 format specific here, as 512 byte inodes can be
> created with v4 filesystems as well.

It's an RFC, and so i've just done the minimum I need to do to
verify it is working corectly. Indeed, I'm not sure it is all there
yet, as I haven't tested increased inode alignments on older
kernels. So I'm not sure whether it will need a feature bit or
not yet.

The test matrix of having to test everything on v4 and v5 is just
nasty, especially if we are talking about prototyping code. I'd much
prefer to bring things to v5 filesytsems where we have much lower
exposure and risk of corruption problems, and then when we know it's
solid because of the QA we've done on it, then we can expose the
majority of the XFS userbase to it by bringing it back to v4

As i've said before - if someone wants to bring new features to v4
filesystems sooner than I do, then they need to step up and do the
work themselves, because I don't have the time and resources to
fully verify new features on v4 filesystem formats...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>