[Top] [All Lists]

Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 7 Sep 2013 07:55:00 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130906162701.GA9994@xxxxxxxxxxxxx>
References: <1378382015-16026-1-git-send-email-david@xxxxxxxxxxxxx> <1378382015-16026-2-git-send-email-david@xxxxxxxxxxxxx> <20130905190407.GA603@xxxxxxxxxxxxx> <20130905235412.GN12779@dastard> <20130906162701.GA9994@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 06, 2013 at 09:27:01AM -0700, Christoph Hellwig wrote:
> On Fri, Sep 06, 2013 at 09:54:12AM +1000, Dave Chinner wrote:
> > Fair enough - I thought about that, but then realised we don't
> > really have any "global" shared header files that fit this purpose.
> > The only two really are xfs_fs.h - which is used for ioctl interface
> > definitions - and xfs_types.h which is used for type definitions,
> > not structure instances...
> > 
> > So I'm not really sure where we'd put something like this without
> > creating a new header file, and I don't really want to do that,
> > either.
> We might need a new one, the headers still need major work anyway.
> If we start with
>       xfs*_format.h - purely disk format
>       xfs_fs.h - ioctl and userspace ABI constants
> an
>       xfs_shared.h
> and
>       xfs_kernel.h

OK. I'm not a great fan of the "xfs_shared.h" name, I'll see if I
can come up with something better....

> seem like logical additions to move most of the misc headers to instead
> of all the silly ones for just a handful or two worth of prototypes.
> Note that a few non-format bits already sneaked into xfs_format.h
> unfortunately, guess I need to watch more closely :)

They did, for the same reason as I put these ones there. I'll move
them to the "xfs_shared.h" once I create it....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>