xfs
[Top] [All Lists]

Re: [PATCH 40/55] xfs: make struct xfs_perag kernel only

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH 40/55] xfs: make struct xfs_perag kernel only
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 7 Sep 2013 07:50:37 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <522A199D.9040509@xxxxxxx>
References: <1378332359-14737-1-git-send-email-david@xxxxxxxxxxxxx> <1378332359-14737-41-git-send-email-david@xxxxxxxxxxxxx> <522A199D.9040509@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 06, 2013 at 01:06:21PM -0500, Mark Tinguely wrote:
> On 09/04/13 17:05, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@xxxxxxxxxx>
> >
> >The struct xfs_perag has many kernel-only definitions in it,
> >requiring a __KERNEL__ guard so userspace can use it to. Move it to
> >xfs_mount.h so that it it kernel-only, and let userspace redefine
> >it's own version of the structure containing only what it needs.
> >This gets rid of another __KERNEL__ check in the XFS header files.
> >
> >Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> >---
> 
> Yeah, this is the end of the kernel / user sync part of the series.
> Thanks Dave.
> 
> The major difference seem to come from this series user patch 31/55.
> 
> Other differences between kernel/user header/sources are in:
> include major difference to TOT:
> struct xfs_perag is in xfs_ag.h user and xfs_mount.h in kernel.

It is in include/libxfs.h in userspace, as it is different to the
version that the kernel uses.

> some differences between
> xfs_alloc_btree.c xfs_bmap_btree.c

btree trace code is the difference here - that needs to be unified
but userspace has different infrastructure right now. Not important
right now.

> xfs_btree.c

readahead functions are missing. userspace defined readhead to a
nop, so not a high priority. It should be done, though.

> xfs_ialloc_btree.c

btree trace code again.

> xfs_inode_buf.c

Doesn't have the new log readahead verifier support, and doesn't do
the "no inode read on create" shortcut which we shouldn't do in
userspace, anyway. Minor differences, not immediately important.

Oh, uuid/platform_uuid thingy. Will need to clean that up, too, on
the next round of updates.

> xfs_rtalloc.c

Not yet split up.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>