xfs
[Top] [All Lists]

Re: [PATCH 31/55] libxfs: switch over to xfs_sb.c and remove xfs_mount.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 31/55] libxfs: switch over to xfs_sb.c and remove xfs_mount.c
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 06 Sep 2013 16:43:21 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130906214021.GD12541@dastard>
References: <1378332359-14737-1-git-send-email-david@xxxxxxxxxxxxx> <1378332359-14737-32-git-send-email-david@xxxxxxxxxxxxx> <522A1BCA.6010500@xxxxxxx> <20130906214021.GD12541@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/06/13 16:40, Dave Chinner wrote:
On Fri, Sep 06, 2013 at 01:15:38PM -0500, Mark Tinguely wrote:
On 09/04/13 17:05, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

Now that the kernel code has split the superblock specific code out
of xfs_mount.c, we don't need xfs_mount.c anymore. Copy in xfs_sb.c
and remove xfs_mount.c

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

user equivalent of the for Linux 3.12 kernel patch 20/49.
This patch leaves xfs_sb.c/xfs_sb.h difference.

For example in xfs_sb.h the user header is missing the project inode
test in xfs_is_quota_inode().

Shouldn't xfs_sb.[ch] synced to the kernel files at this point?

No, they don't end up perfectly synced because of the different
error messages in the code and some of the checks aren't relevant to
userspace. Looks like there's some new whitespace differences, and
that I missed a pquota change as well. I'll send a new version later
today.

Cheers,

Dave.

Okay. Thanks for the work. We can bring that series in early next week.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>