xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: factor all the kmalloc-or-vmalloc fallback allocati

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: factor all the kmalloc-or-vmalloc fallback allocations
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 06 Sep 2013 15:37:42 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1378119180-31380-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1378119180-31380-1-git-send-email-david@xxxxxxxxxxxxx> <1378119180-31380-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/02/13 05:53, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

We have quite a few places now where we do:

        x = kmem_zalloc(large size)
        if (!x)
                x = kmem_zalloc_large(large size)

and do a similar dance when freeing the memory. kmem_free() already
does the correct freeing dance, and kmem_zalloc_large() is only ever
called in these constructs, so just factor it all into
kmem_zalloc_large() and kmem_free().

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Good start on the allocation changes.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>