xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: don't assert fail on bad inode numbers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: don't assert fail on bad inode numbers
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 06 Sep 2013 14:54:26 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1378208858-20557-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1378208858-20557-1-git-send-email-david@xxxxxxxxxxxxx> <1378208858-20557-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/03/13 06:47, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

Let the inode verifier do it's work by returning an error when we
fail to find correct magic numbers in an inode buffer.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks okay - the xfs_buf_ioerror() sets the error code for the caller to detect.

We talked about this in June:
 http://oss.sgi.com/archives/xfs/2013-06/msg00712.html

Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>