xfs
[Top] [All Lists]

Re: [PATCH 51/55] xfs: fix calculation of the number of node entries in

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 51/55] xfs: fix calculation of the number of node entries in a dir3 node
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 06 Sep 2013 13:53:25 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1378332359-14737-52-git-send-email-david@xxxxxxxxxxxxx>
References: <1378332359-14737-1-git-send-email-david@xxxxxxxxxxxxx> <1378332359-14737-52-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/04/13 17:05, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

The calculation doesn't take into account the size of the dir v3
header, so overestimates the hash entries in a node. This causes
directory buffer overruns when splitting and merging nodes.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

Looks good, same as kernel commit 37804376.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>