| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 38/55] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Fri, 06 Sep 2013 12:29:38 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1378332359-14737-39-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1378332359-14737-1-git-send-email-david@xxxxxxxxxxxxx> <1378332359-14737-39-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 09/04/13 17:05, Dave Chinner wrote: From: Dave Chinner<dchinner@xxxxxxxxxx> It's actually an ifndef section, which means it is only included in userspace. however, it's deep within the libxfs code, so it's unlikely that the condition checked in userspace can actually occur (search an empty leaf) through the libxfs interfaces. i.e. if it can happen in usrspace, it can happen in the kernel, so remove it from userspace too.... Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx> --- user equivalent of the for Linux 3.12 kernel patch 31/50. Looks good to me. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| Previous by Date: | Re: [PATCH 37/55] xfs: remove __KERNEL__ from debug code, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH 39/55] xfs: move kernel specific type definitions to xfs.h, Mark Tinguely |
| Previous by Thread: | [PATCH 38/55] xfs: remove __KERNEL__ check from xfs_dir2_leaf.c, Dave Chinner |
| Next by Thread: | [PATCH 22/55] xfs: split out on-disk transaction definitions, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |