| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Fri, 6 Sep 2013 09:27:01 -0700 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20130905235412.GN12779@dastard> |
| References: | <1378382015-16026-1-git-send-email-david@xxxxxxxxxxxxx> <1378382015-16026-2-git-send-email-david@xxxxxxxxxxxxx> <20130905190407.GA603@xxxxxxxxxxxxx> <20130905235412.GN12779@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 06, 2013 at 09:54:12AM +1000, Dave Chinner wrote:
> Fair enough - I thought about that, but then realised we don't
> really have any "global" shared header files that fit this purpose.
> The only two really are xfs_fs.h - which is used for ioctl interface
> definitions - and xfs_types.h which is used for type definitions,
> not structure instances...
>
> So I'm not really sure where we'd put something like this without
> creating a new header file, and I don't really want to do that,
> either.
We might need a new one, the headers still need major work anyway.
If we start with
xfs*_format.h - purely disk format
xfs_fs.h - ioctl and userspace ABI constants
an
xfs_shared.h
and
xfs_kernel.h
seem like logical additions to move most of the misc headers to instead
of all the silly ones for just a handful or two worth of prototypes.
Note that a few non-format bits already sneaked into xfs_format.h
unfortunately, guess I need to watch more closely :)
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | great big market, tracy |
|---|---|
| Next by Date: | Re: [PATCH 35/55] xfs: move swap extent code to xfs_extent_ops, Mark Tinguely |
| Previous by Thread: | Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h, Dave Chinner |
| Next by Thread: | Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |