xfs
[Top] [All Lists]

Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 6 Sep 2013 09:54:12 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130905190407.GA603@xxxxxxxxxxxxx>
References: <1378382015-16026-1-git-send-email-david@xxxxxxxxxxxxx> <1378382015-16026-2-git-send-email-david@xxxxxxxxxxxxx> <20130905190407.GA603@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 05, 2013 at 12:04:07PM -0700, Christoph Hellwig wrote:
> On Thu, Sep 05, 2013 at 09:53:33PM +1000, Dave Chinner wrote:
> > All of the buffer operations structures are needed to be exported
> > for xfs_db, so move them all to a common location rather than
> > spreading them all over the place. They are verifying the on-disk
> > format, so xfs_format.h is as good a place as any.
> > 
> > Don't move the dir2 buffer verifiers - they are already shared in a
> > "central" place for all the dir2 and moving them just requires
> > adding more include files...
> 
> Please only keep the actual format in the _format.h headers and use
> a different shared header for incore bits that can be shared.

Fair enough - I thought about that, but then realised we don't
really have any "global" shared header files that fit this purpose.
The only two really are xfs_fs.h - which is used for ioctl interface
definitions - and xfs_types.h which is used for type definitions,
not structure instances...

So I'm not really sure where we'd put something like this without
creating a new header file, and I don't really want to do that,
either.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>