xfs
[Top] [All Lists]

Re: [PATCH 05/55] libxfs: ensure btree root split sets blkno correctly

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/55] libxfs: ensure btree root split sets blkno correctly
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 05 Sep 2013 10:37:12 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1378332359-14737-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1378332359-14737-1-git-send-email-david@xxxxxxxxxxxxx> <1378332359-14737-6-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 09/04/13 17:05, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

For CRC enabled filesystems, the BMBT is rooted in an inode, so it
passes through a difference code path on root splits to the
freespace and inode btrees. The inode based btree root has a
corruption problem on split - it's the same problem we saw in the
directory/attr code where headers are memcpy()d from one block to
another without updating the self describing metadata.

Simple fix - when copying the header out of the root block, make
sure the block number is updated correctly.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---

This patch has not changed since last posting. It brings xfsprogs to
kernel commit ade1335a

Review-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>