xfs
[Top] [All Lists]

Re: [RFC PATCH 04/11] xfs: update inode allocation transaction reservati

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [RFC PATCH 04/11] xfs: update inode allocation transaction reservations for finobt
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 5 Sep 2013 10:59:46 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1378232708-57156-5-git-send-email-bfoster@xxxxxxxxxx>
References: <1378232708-57156-1-git-send-email-bfoster@xxxxxxxxxx> <1378232708-57156-5-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 03, 2013 at 02:25:01PM -0400, Brian Foster wrote:
> Update inode allocation transaction reservations for the finobt. A
> create via record modification requires a log reservation for the
> additional finobt record. Any such allocation could result in an
> finobt removal if the inode chunk has become fully allocated, thus
> we include a reservation for a finobt btree merge as well.
> Allocation of a new inode chunk must account for splits in the
> finobt as well as the existing ialloc tree.

These transaction reservation changes are only necessary for
filesystems with free inode btrees, otherwise they just use more log
space than is necessary.

Can you add helper functions for the free inode btree reservations,
and have them return 0 when the feature is not enabled? That way the
code stays pretty clean, is self documenting and doesn't take
unnecessary space when the feature is not enabled....

> Also update XFS_IALLOC_SPACE_RES() to reserve data blocks for
> finobt split/merge scenarios.

Needs to handle the enabled/disabled case, too.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>