On Mon, Sep 02, 2013 at 12:15:59PM +1000, Dave Chinner wrote:
> On Fri, Aug 30, 2013 at 04:21:20PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > So fix up the export in xfs_dir2.h that is needed by userspace.
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Well, this patch now causes a compilation failure. Why?
> xfs_dir3_sfe_put_ino() got marked as static because it didn't have a
> matching export.
> Perhaps we should be a little less hasty in merging auto-generated
> patches from random build-farms? The patch was wrong - fixing the
> prototype like in v1 of this patch was the correct thing to do....
> So, the updated patch below adds the revert.
> PS: Ben, when you merge a patch from a reply in an email thread,
> can you please pull the commit subject line from the patch, not the
> title of the email thread? One of the recent commits got it wrong.
> i.e. commit 3780437
> "XFS: Assertion failed: first <= last && last < BBTOB(bp->b_length), file:"
> should have had the title
> "xfs: fix calculation of the number of node entries in a dir3 node"
I'll keep an eye out, thanks.
> Dave Chinner
> xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_put_ino
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> So fix up the export in xfs_dir2.h that is needed by userspace.
> Now xfs_dir3_sfe_put_ino has been made static. Revert 98f7462 ("xfs:
> xfs_dir3_sfe_put_ino can be static") to being non static so that the
> code shared with userspace is identical again.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
Ah.. sorry I missed that it's used in your userspace series. Could you repost
your userspace series soon?
Reviewed-by: Ben Myers <bpm@xxxxxxx>