| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/3] xfstests: Obey mkfs options for sized filesystems on XFS |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 3 Sep 2013 00:34:50 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1378167295-7566-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1378167295-7566-1-git-send-email-david@xxxxxxxxxxxxx> <1378167295-7566-3-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Sep 03, 2013 at 10:14:54AM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > The XFS implementation of _scratch_mkfs_sized ignores MKFS_OPTIONS > when a custom block size is set and so isn't testing things like > CRCs on such sized filesytsems. Fix this by ensuring we don't try to > override the block size is it is set in MKFS_OPTIONS. xfs/204 shows > this problem. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good. Maybe someone more familar with the other mkfs tools should cross-check those as well. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] xfstests: generic/204 should call _check_scratch_fs, Christoph Hellwig |
|---|---|
| Next by Date: | SatÄnalma ve SatÄÅ Profesyonelleri BuluÅmasÄ, Faruk Alemdar |
| Previous by Thread: | [PATCH 2/3] xfstests: Obey mkfs options for sized filesystems on XFS, Dave Chinner |
| Next by Thread: | Your two incoming mails, nagios nagios. nagios |
| Indexes: | [Date] [Thread] [Top] [All Lists] |