| To: | NamJae Jeon <linkinjeon@xxxxxxxxx> |
|---|---|
| Subject: | Re: [v2, 4/7] xfsprogs: xfsio: add support FALLOC_FL_COLLAPSE_RANGE for fallocate |
| From: | Wang Shilong <wangshilong1991@xxxxxxxxx> |
| Date: | Tue, 03 Sep 2013 00:03:29 +0800 |
| Cc: | Wang Shilong <wangshilong1991@xxxxxxxxx>, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, Namjae Jeon <linkinjeon@xxxxxxxxx>, a.sangwan@xxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, david@xxxxxxxxxxxxx linux-fsdevel@xxxxxxxxxxxxxxx, hch@xxxxxxxxxxxxx, elder@xxxxxxxxxx, bpm@xxxxxxx, adilger.kernel@xxxxxxxxx, tytso@xxxxxxx, mtk.manpages@xxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:cc:message-id:user-agent:mime-version :content-type:content-transfer-encoding; bh=HHirONHYF50pDSbWMu2CTyh5vm2d3q1g+Lv8vXDIvNU=; b=hahF4GEH0OBaV4PhuvkF7NssdlrVywP7hVaui0jSIB4rZnNedpm5ZrBR4XafTouQn4 pchnbUdlNdK5lioOZSJQrhiuYiABDv3XFjRk9lgO6K0/YXGKTQO/kuyuq1B/IGTj6mYx Dr5neTVOkY0sB2pduCrv4vD7EGJhhVAsATvHyxnfvHa+irmhvd56LN5NmyvKeLa19c9r 9GIURYid+8WgQldXVAqxrqXUaWuuZ8Z/12jJrhq493p78a4VhVzFdydBaMSeUmMqnMOx JiNOkGTSD5tl5vJAjNwH7SCC7iTyMil/0BSjr73AxuXRYxs9/nrIvFof+sCQS183l/uE 8vHg== |
| User-agent: | Heirloom mailx 12.5 7/5/10 |
Hello, Using checkpatch.pl, i get the following warnings(errors):
ERROR: space required before the open parenthesis '('
#79: FILE: io/prealloc.c:223:
+ if(!offset_length(argv[1], argv[2], &segment))
WARNING: line over 80 characters
#104: FILE: io/prealloc.c:315:
+ _("de-allocates space and nullify the hole by shifting extents
into it");
total: 1 errors, 1 warnings, 81 lines checked
patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Thanks, Wang
Notice: this is an automatically generated by shell script
Any problems please contact: wangshilong1991@xxxxxxxxx
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [v2,6/7] xfstest: Add test case to test multiple collapse range call, Wang Shilong |
|---|---|
| Next by Date: | Re: [v4, 4/7] xfsprogs: xfsio: add support FALLOC_FL_COLLAPSE_RANGE for fallocate, Wang Shilong |
| Previous by Thread: | Re: [v2,6/7] xfstest: Add test case to test multiple collapse range call, Wang Shilong |
| Next by Thread: | Re: [v4, 4/7] xfsprogs: xfsio: add support FALLOC_FL_COLLAPSE_RANGE for fallocate, Wang Shilong |
| Indexes: | [Date] [Thread] [Top] [All Lists] |