| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfs: fix some minor sparse warnings |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 2 Sep 2013 01:19:54 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1378092179-24973-3-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1378092179-24973-1-git-send-email-david@xxxxxxxxxxxxx> <1378092179-24973-3-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> --- a/fs/xfs/xfs_dquot_item.c
> +++ b/fs/xfs/xfs_dquot_item.c
> @@ -143,6 +143,8 @@ STATIC uint
> xfs_qm_dquot_logitem_push(
> struct xfs_log_item *lip,
> struct list_head *buffer_list)
> + __releases(&lip->li_ailp->xa_lock)
> + __acquires(&lip->li_ailp->xa_lock)
> {
Having these markers indented the same amount as the parameters isn't
very readable. Maybe give them another tab level?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] xfs: fix endian warning in xlog_recover_get_buf_lsn(), Christoph Hellwig |
|---|---|
| Next by Date: | техническая безопасность, комитет по охране окружающей среды |
| Previous by Thread: | [PATCH 2/2] xfs: fix some minor sparse warnings, Dave Chinner |
| Next by Thread: | Re: [PATCH 2/2] xfs: fix some minor sparse warnings, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |