xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: ensure we copy buffer type in da btree root splits

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: ensure we copy buffer type in da btree root splits
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 2 Sep 2013 01:17:25 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1378081921-18570-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1378081921-18570-1-git-send-email-david@xxxxxxxxxxxxx> <1378081921-18570-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Sep 02, 2013 at 10:32:01AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When splitting the root of the da btree, we shuffled data between
> buffers and the structures that track them. At one point, we copy
> data and state from one buffer to another, including the ops
> aasociated with the buffer. When we do this, we also need to copy
> the buffer type associated with the buf log item so that the buffer
> is logged correctly. If we don't do that, log recovery won't
> recognise it and hence it won't recalculate the CRC on the buffer
> after recovery. This leads to a directory block that can't be read
> after recovery has run.
> 
> Found by inspection after finding the same problem with remote
> symlink buffers.

It would be great to find a way to trigger this in QA as this shows
another area lacking coverage.

<Prev in Thread] Current Thread [Next in Thread>