xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: set remote symlink buffer type for recovery

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: set remote symlink buffer type for recovery
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 2 Sep 2013 01:16:25 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1378081921-18570-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1378081921-18570-1-git-send-email-david@xxxxxxxxxxxxx> <1378081921-18570-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Sep 02, 2013 at 10:32:00AM +1000, Dave Chinner wrote:
> errors, and subsequent reads of the symlink failing CRC
> verification. Found via fsstress + godown.

Can you make sure xfstests triggers this case, please?

> +                     xfs_trans_buf_set_type(tp, bp, XFS_BLFT_SYMLINK_BUF);
>                       xfs_trans_log_buf(tp, bp, 0, (buf + byte_cnt - 1) -
>                                                       (char *)bp->b_addr);

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>