xfs
[Top] [All Lists]

Re: [PATCH V3] mkfs: add noalign option to usage()

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH V3] mkfs: add noalign option to usage()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 30 Aug 2013 20:23:47 -0500
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1377882590-22852-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1377882590-22852-1-git-send-email-cmaiolino@xxxxxxxxxx>
On Aug 30, 2013, at 12:09 PM, Carlos Maiolino <cmaiolino@xxxxxxxxxx> wrote:

> Although it has been added to manpage, there is no information about the
> existence of noalign option into the usage().
> 
> Changelog:
> 
> V2: Remove space in comma separated options
> V3: Aligned the option together with another alignment options to make mutual
>    exclusive options more visible
> 
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4bdacee..b0c3ce5 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3032,7 +3032,7 @@ usage( void )
> /* blocksize */        [-b log=n|size=num]\n\
> /* metadata */        [-m crc=[0|1]\n\
> /* data subvol */    [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
> -                (sunit=value,swidth=value|su=num,sw=num),\n\
> +                (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
>                sectlog=n|sectsize=num\n\
> /* force overwrite */    [-f]\n\
> /* inode size */    [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> -- 
> 1.8.1.4
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>