xfs
[Top] [All Lists]

Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue

To: Eric Sandeen <esandeen@xxxxxxxxxx>
Subject: Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 30 Aug 2013 15:21:06 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <44DD3D7C-C7C8-483C-BA6D-DFF31E6363ED@xxxxxxxxxx>
References: <4F75DE2B.7030807@xxxxxxxxxx> <20130823201146.GW5262@xxxxxxx> <44DD3D7C-C7C8-483C-BA6D-DFF31E6363ED@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Aug 23, 2013 at 04:17:07PM -0400, Eric Sandeen wrote:
> On Aug 23, 2013, at 3:11 PM, Ben Myers <bpm@xxxxxxx> wrote:
> 
> > Hey Eric,
> > 
> > On Fri, Mar 30, 2012 at 11:24:11AM -0500, Eric Sandeen wrote:
> >> This ASSERT is testing an if_flags flag value against
> >> a di_aformat enum value.  di_aformat is never assigned
> >> XFS_IFINLINE.
> >> 
> >> This happens to work for now, because XFS_IFINLINE has
> >> the same value as XFS_DINODE_FMT_LOCAL, and that's tested
> >> just before we call this function.
> >> 
> >> However, I think the intention is to assert that we have
> >> read in the data, i.e. XFS_IFINLINE on if_flags, before
> >> we use if_data.  This is done in other places through the
> >> code as well.
> >> 
> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> > 
> > Looks like this one fell through the cracks.  You still interested in 
> > merging
> > it?
> > 
> Yep - it's fallen out of my brain by mow but if it was correct then I think 
> it's correct now...

Applied.

<Prev in Thread] Current Thread [Next in Thread>