xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix bad dquot buffer size in log recovery readahead

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix bad dquot buffer size in log recovery readahead
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 30 Aug 2013 13:38:51 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130827214534.GZ5262@xxxxxxx>
References: <1377573943-25770-1-git-send-email-david@xxxxxxxxxxxxx> <20130827214534.GZ5262@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Aug 27, 2013 at 04:45:34PM -0500, Ben Myers wrote:
> On Tue, Aug 27, 2013 at 01:25:43PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > xfstests xfs/087 fails 100% reliably with this assert:
> > 
> > XFS (vdb): Mounting Filesystem
> > XFS (vdb): Starting recovery (logdev: internal)
> > XFS: Assertion failed: bp->b_flags & XBF_STALE, file: fs/xfs/xfs_buf.c, 
> > line: 548
> > 
> > while trying to read a dquot buffer in xlog_recover_dquot_ra_pass2().
> > 
> > The issue is that the buffer length to read that is passed to
> > xfs_buf_readahead is in units of filesystem blocks, not disk blocks.
> > (i.e. FSB, not daddr). Fix it but putting the correct conversion in
> > place.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Looks good.
> 
> Reviewed-by: Ben Myers <bpm@xxxxxxx>

Also applied this one...

<Prev in Thread] Current Thread [Next in Thread>