xfs
[Top] [All Lists]

Re: [PATCH v2] mkfs: add noalign option to usage()

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH v2] mkfs: add noalign option to usage()
From: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Date: Fri, 30 Aug 2013 14:03:28 -0300
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <521F782E.2030400@xxxxxxxxxxx>
References: <1377792190-21220-1-git-send-email-cmaiolino@xxxxxxxxxx> <521F782E.2030400@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 29, 2013 at 11:34:54AM -0500, Eric Sandeen wrote:
> On 8/29/13 11:03 AM, Carlos Maiolino wrote:
> > Although it has been added to manpage, there is no information about the
> > existence of noalign option into the usage().
> > 
> > Changelog:
> > 
> > V2: Remove space in comma separated options
> > 
> > Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> > ---
> >  mkfs/xfs_mkfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> > index 4bdacee..ef1d758 100644
> > --- a/mkfs/xfs_mkfs.c
> > +++ b/mkfs/xfs_mkfs.c
> > @@ -3033,7 +3033,7 @@ usage( void )
> >  /* metadata */             [-m crc=[0|1]\n\
> >  /* data subvol */  [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
> >                         (sunit=value,swidth=value|su=num,sw=num),\n\
> > -                       sectlog=n|sectsize=num\n\
> > +                       noalign,sectlog=n|sectsize=num\n\
> 
> I'd really rather see it as I suggested, for clarity.
> 
> su/sw vs. sunit/swidth vs. noalign are mutually exclusive.
> 
> su/sw & sunit/swidth are shown to be so via the (A|B) notation.
> 
> Adding noalign outside the (A|B) makes it look like it can be specified in
> addition to alignment options, which really makes no sense.
> 
> Can you do:
> 
> -                         (sunit=value,swidth=value|su=num,sw=num),\n\
> +                         (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
> 
> instead?
Sure, didn't think about mutual exclusive options being packed together, will
send a v3
> 
> -Eric
> 
> >  /* force overwrite */      [-f]\n\
> >  /* inode size */   [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> >                         projid32bit=0|1]\n\
> > 
> 

-- 
Carlos

<Prev in Thread] Current Thread [Next in Thread>