xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_put_ino
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Fri, 30 Aug 2013 08:56:38 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1377843681-31878-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1377843681-31878-1-git-send-email-david@xxxxxxxxxxxxx> <1377843681-31878-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/30/13 01:21, Dave Chinner wrote:
From: Dave Chinner<dchinner@xxxxxxxxxx>

So fix up the export in xfs_dir2.h that is needed by userspace.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---
  fs/xfs/xfs_dir2.h | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_dir2.h b/fs/xfs/xfs_dir2.h
index 768ddad..9910401 100644
--- a/fs/xfs/xfs_dir2.h
+++ b/fs/xfs/xfs_dir2.h
@@ -70,8 +70,9 @@ extern void xfs_dir2_sf_put_parent_ino(struct xfs_dir2_sf_hdr 
*sfp,
                xfs_ino_t ino);
  extern xfs_ino_t xfs_dir3_sfe_get_ino(struct xfs_mount *mp,
                struct xfs_dir2_sf_hdr *sfp, struct xfs_dir2_sf_entry *sfep);
-extern void xfs_dir2_sfe_put_ino( struct xfs_dir2_sf_hdr *,
-               struct xfs_dir2_sf_entry *sfep, xfs_ino_t ino);
+extern void xfs_dir3_sfe_put_ino(struct xfs_mount *mp,
+               struct xfs_dir2_sf_hdr *hdr, struct xfs_dir2_sf_entry *sfep,
+               xfs_ino_t ino);

  extern int xfs_dir2_isblock(struct xfs_trans *tp, struct xfs_inode *dp, int 
*r);
  extern int xfs_dir2_isleaf(struct xfs_trans *tp, struct xfs_inode *dp, int 
*r);

Okay xfs_dir2_sfe_put_ino() does not exist. xfs_dir3_sfe_put_ino() is remotely used in xfs_repair but not in kernel.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>