xfs
[Top] [All Lists]

Re: [PATCH v2] mkfs: add noalign option to usage()

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH v2] mkfs: add noalign option to usage()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 29 Aug 2013 11:34:54 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1377792190-21220-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1377792190-21220-1-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 8/29/13 11:03 AM, Carlos Maiolino wrote:
> Although it has been added to manpage, there is no information about the
> existence of noalign option into the usage().
> 
> Changelog:
> 
> V2: Remove space in comma separated options
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> ---
>  mkfs/xfs_mkfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4bdacee..ef1d758 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3033,7 +3033,7 @@ usage( void )
>  /* metadata */               [-m crc=[0|1]\n\
>  /* data subvol */    [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
>                           (sunit=value,swidth=value|su=num,sw=num),\n\
> -                         sectlog=n|sectsize=num\n\
> +                         noalign,sectlog=n|sectsize=num\n\

I'd really rather see it as I suggested, for clarity.

su/sw vs. sunit/swidth vs. noalign are mutually exclusive.

su/sw & sunit/swidth are shown to be so via the (A|B) notation.

Adding noalign outside the (A|B) makes it look like it can be specified in
addition to alignment options, which really makes no sense.

Can you do:

-                           (sunit=value,swidth=value|su=num,sw=num),\n\
+                           (sunit=value,swidth=value|su=num,sw=num|noalign),\n\

instead?

-Eric

>  /* force overwrite */        [-f]\n\
>  /* inode size */     [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
>                           projid32bit=0|1]\n\
> 

<Prev in Thread] Current Thread [Next in Thread>