xfs
[Top] [All Lists]

Re: [PATCH] mkfs: add noalign option to usage()

To: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Subject: Re: [PATCH] mkfs: add noalign option to usage()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 29 Aug 2013 10:56:20 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1377789991-17236-1-git-send-email-cmaiolino@xxxxxxxxxx>
References: <1377789991-17236-1-git-send-email-cmaiolino@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 8/29/13 10:26 AM, Carlos Maiolino wrote:
> Although it has been added to manpage, there is no information about the
> existence of noalign option into the usage().
> 
> Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> ---
>  mkfs/xfs_mkfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4bdacee..65630d4 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3033,7 +3033,7 @@ usage( void )
>  /* metadata */               [-m crc=[0|1]\n\
>  /* data subvol */    [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
>                           (sunit=value,swidth=value|su=num,sw=num),\n\
> -                         sectlog=n|sectsize=num\n\
> +                         noalign, sectlog=n|sectsize=num\n\

SUPER nitpick, but other options don't have a space after the comma.

And noalign is exclusive to sunit/sw options (right?), so maybe the
output should look like:

/* data subvol */       [-d agcount=n,agsize=n,file,name=xxx,size=num,
                            (sunit=value,swidth=value|su=num,sw=num|noalign),
                            sectlog=n|sectsize=num

also: I think it's hilarious that we emit C comment strings in usage() ;)

-Eric

>  /* force overwrite */        [-f]\n\
>  /* inode size */     [-i log=n|perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
>                           projid32bit=0|1]\n\
> 


<Prev in Thread] Current Thread [Next in Thread>