xfs
[Top] [All Lists]

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V2

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V2
From: David Sterba <dsterba@xxxxxxx>
Date: Thu, 29 Aug 2013 15:21:58 +0200
Cc: Josef Bacik <jbacik@xxxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <520A8B1D.60307@xxxxxxxxxx>
Mail-followup-to: dsterba@xxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
References: <1376422458-2339-1-git-send-email-jbacik@xxxxxxxxxxxx> <520A8B1D.60307@xxxxxxxxxx>
Reply-to: dsterba@xxxxxxx
User-agent: Mutt/1.5.21 (2012-12-30)
On Tue, Aug 13, 2013 at 02:38:05PM -0500, Eric Sandeen wrote:
> > +. ./common/rc
> > +. ./common/filter
> > +
> > +# real QA test starts here
> > +_supported_fs btrfs
> > +_supported_os Linux
> > +_require_scratch
> > +
> > +_scratch_mkfs > /dev/null 2>&1
> > +_scratch_mount
> > +
> > +# This will be set to subvolid 256.  If this ever changes in the future for
> > +# whatever reason we'll have to pull the subvolid out of the subvol list 
> > command
> > +# but since it's a newly mkfs'ed fs we should be fine with this.
> 
> . . . and then you grab it out of the subvol list command anyway ;)
> 
> So really this comment should go, and it sure would be nice to have 
> a btrfs_get_subvolid() helper for future generations...

This is available in the 'btrfs subvol show /subvol':

# btrfs subvol show subv1
/mnt/a15/subv1
        Name:                   subv1
        uuid:                   cf010ad0-38bf-7a42-88be-3360f68cd335
        Parent uuid:            e6543f70-5d38-1845-b976-d18095860bdf
        Creation time:          2013-08-29 15:18:18
        Object ID:              258
        Generation (Gen):       6
        Gen at creation:        6
        Parent:                 5
        Top Level:              5
        Flags:                  readonly
        Snapshot(s):

Though it involves grep as well.

david

<Prev in Thread] Current Thread [Next in Thread>