[Top] [All Lists]

Re: [PATCH] Re: XFS: Assertion failed: first <= last && last < BBTOB(bp-

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Re: XFS: Assertion failed: first <= last && last < BBTOB(bp->b_length), file: fs/xfs/xfs_trans_buf.c, line: 568
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Thu, 29 Aug 2013 07:37:42 -0500
Cc: Brian Foster <bfoster@xxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130826041330.GU6023@dastard>
References: <52165830.8050006@xxxxxxxxxx> <20130826041330.GU6023@dastard>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/25/13 23:13, Dave Chinner wrote:
xfs: fix calculation of the number of node entries in a dir3 node

From: Dave Chinner<dchinner@xxxxxxxxxx>

The calculation doesn't take into account the size of the dir v3
header, so overestimates the hash entries in a node. This causes
directory buffer overruns when splitting and merging nodes.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>

Makes sense to me for the inode v3 assert.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

The remove assert with the same test must be in common code; it can be triggered in both versions of the inode (Linux 3.10 - TOT). The assert on the remove may require the test to be run until the filesystem is full before doing the remove.

<Prev in Thread] Current Thread [Next in Thread>