Re: [PATCH] Re: XFS: Assertion failed: first <= last && last < BBTOB(bp->b_length), file: fs/xfs/xfs_trans_buf.c, line: 568

[Mark Tinguely <tinguely@xxxxxxx>]

On 08/25/13 23:13, Dave Chinner wrote:
> xfs: fix calculation of the number of node entries in a dir3 node
>
> From: Dave Chinner<dchinner@xxxxxxxxxx>
>
> The calculation doesn't take into account the size of the dir v3
> header, so overestimates the hash entries in a node. This causes
> directory buffer overruns when splitting and merging nodes.
>
> Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> ---
Makes sense to me for the inode v3 assert.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

The remove assert with the same test must be in common code; it can be 
triggered in both versions of the inode (Linux 3.10 - TOT). The assert 
on the remove may require the test to be run until the filesystem is 
full before doing the remove.