xfs
[Top] [All Lists]

Re: [PATCH] xfstests: generic/255: Execute only if blocksize <= 4096

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: generic/255: Execute only if blocksize <= 4096
From: chandan <chandan@xxxxxxxxxxxxxxxxxx>
Date: Wed, 28 Aug 2013 13:44:09 +0530
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, sekharan@xxxxxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <521CD7FC.1080706@xxxxxxxxxxx>
References: <2909046.09LYLQvZ6q@xxxxxxxxxxxxxxxxxxxxx> <3942763.p7a9her5Nt@xxxxxxxxxxxxxxxxxxxxx> <521CD7FC.1080706@xxxxxxxxxxx>
User-agent: KMail/4.10.5 (Linux/3.10.9-200.fc19.x86_64; KDE/4.10.5; x86_64; ; )
On Tuesday, August 27, 2013 11:46:52 AM Eric Sandeen wrote:
> On 8/27/13 7:16 AM, chandan wrote:
> > On Monday, August 26, 2013 09:29:31 AM Eric Sandeen wrote:
> >>
> >> Just as a sanity check, does it also fail on xfs for 64k block sizes on 
> >> ppc64?
> >>
> > 
> > Yes, it does fail as shown below:
> > 
> 
> (removing linux-btrfs for now):
> 
> Hohum, I get failures on 2k and even 4k blocksize xfs (and ext4) on ppc64 as 
> well.
> (this was on a 3.10 kernel)
> 
> Have you seen this?
> 
> I guess I'm a little reluctant to restrict the test to <=4k until we 
> understand
> what all the issues are and at least see it passing on the smaller block
> sizes... do they work for you?
> 
> -Eric
>

Eric,

I have posted a patch that fixes _test_generic_punch() to obtain the correct
block size. With that patch applied, the code works for 4k blocksize for
both xfs and ext4.

Even the with the above mentioned fix applied, the code doesn't work with
block sizes != 4k. The extent ranges in 255.out were obtained for 4k block
sizes and hence they don't work for other block sizes. I will repost the
patch to restrict execution of generic/255 only when the block size is 4k.

- chandan

<Prev in Thread] Current Thread [Next in Thread>