xfs
[Top] [All Lists]

[PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: check correct status variable for xfs_inobt_get_rec() call
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Tue, 27 Aug 2013 17:15:45 -0400
Delivered-to: xfs@xxxxxxxxxxx
The call to xfs_inobt_get_rec() in xfs_dialloc_ag() passes 'j' as
the output status variable. The immediately following
XFS_WANT_CORRUPTED_GOTO() checks the value of 'i,' which is from
the previous lookup call and has already been checked. Fix the
corruption check to use 'j.'

Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
---
 fs/xfs/xfs_ialloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_ialloc.c b/fs/xfs/xfs_ialloc.c
index 6bee95d..ccf2fb1 100644
--- a/fs/xfs/xfs_ialloc.c
+++ b/fs/xfs/xfs_ialloc.c
@@ -729,7 +729,7 @@ xfs_dialloc_ag(
                error = xfs_inobt_get_rec(cur, &rec, &j);
                if (error)
                        goto error0;
-               XFS_WANT_CORRUPTED_GOTO(i == 1, error0);
+               XFS_WANT_CORRUPTED_GOTO(j == 1, error0);
 
                if (rec.ir_freecount > 0) {
                        /*
-- 
1.8.1.4

<Prev in Thread] Current Thread [Next in Thread>