xfs
[Top] [All Lists]

Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field

To: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Subject: Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field
From: Mark Tinguely <tinguely@xxxxxxx>
Date: Mon, 26 Aug 2013 10:40:48 -0500
Cc: Ben Myers <bpm@xxxxxxx>, Geoffrey Wehrman <gwehrman@xxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <521993AA.7010301@xxxxxxxxx>
References: <1376304611-22994-1-git-send-email-david@xxxxxxxxxxxxx> <20130819201940.516942026@xxxxxxx> <5212AA1D.3000809@xxxxxxxxxxx> <52137D3D.8060205@xxxxxxx> <20130821000624.GO6023@dastard> <20130821170336.GJ5262@xxxxxxx> <20130822020226.GR6023@dastard> <20130822161456.GB23510@xxxxxxx> <20130822181910.GP5262@xxxxxxx> <521993AA.7010301@xxxxxxxxx>
User-agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0
On 08/25/13 00:18, Michael L. Semon wrote:
On 08/22/2013 02:19 PM, Ben Myers wrote:
Gents,

On Thu, Aug 22, 2013 at 11:14:56AM -0500, Geoffrey Wehrman wrote:
On Thu, Aug 22, 2013 at 12:02:26PM +1000, Dave Chinner wrote:
| I'm very, very, very unhappy about how this situation is unfolding.

As am I.

Mark provided some mkfs code to test the v4 feature bit with, and it
worked fine for me.

Given that we are protected by a feature bit, I feel that pulling in the
v4 feature is considerably less risky than what we did in 3.10, with
Dave still cleaning up his mess in -rc6, so go ahead and call me
reckless:  I've pulled in both v4 and v5 versions of this code.

Mark, please post your mkfs code ASAP, even though Dave hasn't reposted
his userspace series yet.

Everybody gets his code in and nobody is happy.

-Ben

Mark's v4 dirent patches seem to work on 32-bit x86.  I happen to agree
100% with Dave on this issue.  However, lacking a dirent test and
xfs_db skills, I threw everything else and the kitchen sink at
v4-dirent XFS and did not find any evidence to back up Dave's argument.
So I'll tip my cap to Mark for his insight on the matter, hoping that
his testing skills are fine as always.

Thanks!

Michael


Thanks for your thoughts on the subject and tests. In the end, we all want XFS to continue to succeed.

--Mark.

<Prev in Thread] Current Thread [Next in Thread>