[Top] [All Lists]

Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field

Subject: Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Sun, 25 Aug 2013 19:21:23 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=QakUrShio8aiC3ozx0kszd8Z5WpTGbyTQIUdtNDwt1M=; b=W1jFa3+gPtu/WGUzbLSgYMj6OJ+SvmYpYYPzhfFRc+BFAFAy+Q6XLZ4pJrTSEeWxoH kqnt8iqhbwknW2X7MBUdE/JSrBewsCZLuHfncZGdn3NlQxi44Sdcn0cov8cxq0RV7dnz NOKkSAZPAZEyUBq4SkWvouXfOHtDyXbERZPiP4bzvWfX0drU5yApY184danLHKhmpork 4zEw2ZSBYPujcT/XxwLGBq3ufAgz/Ib4kZxgoQf78r0EVtB4wCwNo8m2lcGYa/u0ZxFa F0iQNcV8fIvIE23GFk9y+k80+ZwH0I7vijrzI8vWX1EIVi0Q/ICRKrBlbikKyiYKLLTn LCeA==
In-reply-to: <521993AA.7010301@xxxxxxxxx>
References: <1376304611-22994-1-git-send-email-david@xxxxxxxxxxxxx> <20130819201940.516942026@xxxxxxx> <5212AA1D.3000809@xxxxxxxxxxx> <52137D3D.8060205@xxxxxxx> <20130821000624.GO6023@dastard> <20130821170336.GJ5262@xxxxxxx> <20130822020226.GR6023@dastard> <20130822161456.GB23510@xxxxxxx> <20130822181910.GP5262@xxxxxxx> <521993AA.7010301@xxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 8/25/2013 1:18 AM, Michael L. Semon wrote:
On 08/22/2013 02:19 PM, Ben Myers wrote:

On Thu, Aug 22, 2013 at 11:14:56AM -0500, Geoffrey Wehrman wrote:
On Thu, Aug 22, 2013 at 12:02:26PM +1000, Dave Chinner wrote:
| I'm very, very, very unhappy about how this situation is unfolding.

As am I.

Mark provided some mkfs code to test the v4 feature bit with, and it
worked fine for me.

Given that we are protected by a feature bit, I feel that pulling in the
v4 feature is considerably less risky than what we did in 3.10, with
Dave still cleaning up his mess in -rc6, so go ahead and call me
reckless:  I've pulled in both v4 and v5 versions of this code.

Mark, please post your mkfs code ASAP, even though Dave hasn't reposted
his userspace series yet.

Everybody gets his code in and nobody is happy.


Mark's v4 dirent patches seem to work on 32-bit x86.  I happen to agree
100% with Dave on this issue.  However, lacking a dirent test and
xfs_db skills, I threw everything else and the kitchen sink at
v4-dirent XFS and did not find any evidence to back up Dave's argument.
So I'll tip my cap to Mark for his insight on the matter, hoping that
his testing skills are fine as always.



BTW, are there any xfstests results times for dirent vs. non-dirent code? For whatever reason, generic/068 is posting noticeably worse numbers for v4-dirent XFS than for both v4 XFS and v5-dirent CRC XFS.

I'm running the tests myself as well, but it will take a while to run them for v4 XFS, v4-dirent XFS, v4-dirent-512b-inode XFS, and v5-dirent-CRC XFS...which kinda speaks to Dave's point about supporting a matrix of filesystems, but I wasn't meaning it that way...

Thanks again!


<Prev in Thread] Current Thread [Next in Thread>