xfs
[Top] [All Lists]

Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH 51/50] xfs: add xfs sb v4 support for dirent filetype field
From: "Michael L. Semon" <mlsemon35@xxxxxxxxx>
Date: Sun, 25 Aug 2013 01:18:34 -0400
Cc: Geoffrey Wehrman <gwehrman@xxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Mark Tinguely <tinguely@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1Ks2ADoGSmPiYxu+9wD4caqg+IV2LUj42qxXa65goas=; b=MR+TAc/nBLP1RIR8ARB5a/nX7lT5PMENqbRR6OvRI8FuHxzfeCZoQDFZJRKFVSkdOQ WjzlmxC0NqQpC51AKXIt+3eiEBcr7PXCnhfpoxo8MIgdzfYKDvdFdAIAbXjRS1kdXB8a SQ7e8g4imi+K9XobY8KOMWUeYVhpK7BGfEFNoIUbLps0OkCmUn5YvUw1+yIev2rSBQZB EIloSixEIGjvpYi87T/CRq2qqRisQH8xi8rmLVkVE56JtDzYMShxUvpvyK0MnxOnJCHK F3xcO/JpJldgNY2yb5rsKuJjnIdtKkYt78oNym5R3WBLBba1wrK5L61NoKyA2BYZPk5c bfXw==
In-reply-to: <20130822181910.GP5262@xxxxxxx>
References: <1376304611-22994-1-git-send-email-david@xxxxxxxxxxxxx> <20130819201940.516942026@xxxxxxx> <5212AA1D.3000809@xxxxxxxxxxx> <52137D3D.8060205@xxxxxxx> <20130821000624.GO6023@dastard> <20130821170336.GJ5262@xxxxxxx> <20130822020226.GR6023@dastard> <20130822161456.GB23510@xxxxxxx> <20130822181910.GP5262@xxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 08/22/2013 02:19 PM, Ben Myers wrote:
> Gents,
> 
> On Thu, Aug 22, 2013 at 11:14:56AM -0500, Geoffrey Wehrman wrote:
>> On Thu, Aug 22, 2013 at 12:02:26PM +1000, Dave Chinner wrote:
>> | I'm very, very, very unhappy about how this situation is unfolding.
>>
>> As am I.
> 
> Mark provided some mkfs code to test the v4 feature bit with, and it
> worked fine for me.
> 
> Given that we are protected by a feature bit, I feel that pulling in the
> v4 feature is considerably less risky than what we did in 3.10, with
> Dave still cleaning up his mess in -rc6, so go ahead and call me
> reckless:  I've pulled in both v4 and v5 versions of this code.
> 
> Mark, please post your mkfs code ASAP, even though Dave hasn't reposted
> his userspace series yet.
> 
> Everybody gets his code in and nobody is happy.
> 
> -Ben

Mark's v4 dirent patches seem to work on 32-bit x86.  I happen to agree 
100% with Dave on this issue.  However, lacking a dirent test and 
xfs_db skills, I threw everything else and the kitchen sink at 
v4-dirent XFS and did not find any evidence to back up Dave's argument. 
So I'll tip my cap to Mark for his insight on the matter, hoping that 
his testing skills are fine as always.

Thanks!

Michael

<Prev in Thread] Current Thread [Next in Thread>