xfs
[Top] [All Lists]

Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue

To: Ben Myers <bpm@xxxxxxx>
Subject: Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
From: Eric Sandeen <esandeen@xxxxxxxxxx>
Date: Fri, 23 Aug 2013 16:17:07 -0400 (EDT)
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20130823201146.GW5262@xxxxxxx>
References: <4F75DE2B.7030807@xxxxxxxxxx> <20130823201146.GW5262@xxxxxxx>
Thread-index: oHUlcuPKuvvBVdfTd3+qTCRK+VbLyg==
Thread-topic: Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
On Aug 23, 2013, at 3:11 PM, Ben Myers <bpm@xxxxxxx> wrote:

> Hey Eric,
> 
> On Fri, Mar 30, 2012 at 11:24:11AM -0500, Eric Sandeen wrote:
>> This ASSERT is testing an if_flags flag value against
>> a di_aformat enum value.  di_aformat is never assigned
>> XFS_IFINLINE.
>> 
>> This happens to work for now, because XFS_IFINLINE has
>> the same value as XFS_DINODE_FMT_LOCAL, and that's tested
>> just before we call this function.
>> 
>> However, I think the intention is to assert that we have
>> read in the data, i.e. XFS_IFINLINE on if_flags, before
>> we use if_data.  This is done in other places through the
>> code as well.
>> 
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> Looks like this one fell through the cracks.  You still interested in merging
> it?
> 
Yep - it's fallen out of my brain by mow but if it was correct then I think 
it's correct now...

Eric

> Thanks,
>    Ben

<Prev in Thread] Current Thread [Next in Thread>