xfs
[Top] [All Lists]

Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] Fix wrong flag ASSERT in xfs_attr_shortform_getvalue
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 23 Aug 2013 15:11:46 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <4F75DE2B.7030807@xxxxxxxxxx>
References: <4F75DE2B.7030807@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
Hey Eric,

On Fri, Mar 30, 2012 at 11:24:11AM -0500, Eric Sandeen wrote:
> This ASSERT is testing an if_flags flag value against
> a di_aformat enum value.  di_aformat is never assigned
> XFS_IFINLINE.
> 
> This happens to work for now, because XFS_IFINLINE has
> the same value as XFS_DINODE_FMT_LOCAL, and that's tested
> just before we call this function.
> 
> However, I think the intention is to assert that we have
> read in the data, i.e. XFS_IFINLINE on if_flags, before
> we use if_data.  This is done in other places through the
> code as well.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks like this one fell through the cracks.  You still interested in merging
it?

Thanks,
        Ben

<Prev in Thread] Current Thread [Next in Thread>