xfs
[Top] [All Lists]

Re: [PATCH v4] xfs: introduce object readahead to log recovery

To: zwu.kernel@xxxxxxxxx
Subject: Re: [PATCH v4] xfs: introduce object readahead to log recovery
From: Ben Myers <bpm@xxxxxxx>
Date: Fri, 23 Aug 2013 14:33:25 -0500
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1376464563-27821-1-git-send-email-zwu.kernel@xxxxxxxxx>
References: <1376464563-27821-1-git-send-email-zwu.kernel@xxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Aug 14, 2013 at 03:16:03PM +0800, zwu.kernel@xxxxxxxxx wrote:
> From: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>
> 
>   It can take a long time to run log recovery operation because it is
> single threaded and is bound by read latency. We can find that it took
> most of the time to wait for the read IO to occur, so if one object
> readahead is introduced to log recovery, it will obviously reduce the
> log recovery time.
> 
> Log recovery time stat:
> 
>           w/o this patch        w/ this patch
> 
> real:        0m15.023s             0m7.802s
> user:        0m0.001s              0m0.001s
> sys:         0m0.246s              0m0.107s
> 
> Signed-off-by: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx>

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied.

<Prev in Thread] Current Thread [Next in Thread>