xfs
[Top] [All Lists]

Re: [PATCH V4] xfstests: don't remove the two first devices from SCRATCH

To: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH V4] xfstests: don't remove the two first devices from SCRATCH_DEV_POOL
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Fri, 23 Aug 2013 14:32:26 -0400
Cc: <xfs@xxxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1377282748; bh=KkNsUcXz0NeWslfvUPZ/CwMKNz0aJ8tOC/PzkVwgaEQ=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=s7Dw7qk3o8ExsE6TNukLzY5ajKkkvC+vSTsqJdxyVmrZo6Mg5CPfef0pYWjGqj+FA DpngVf5PXsCxowOnt4ErB7BiInmg7Zm4DOyNi4I+mIerEoQ45Ary2UwByEp0I1OX1b 5dSA3BMxaYY6RjjGSOYRf6atRVyliaPCq2Z7PBfs=
In-reply-to: <1377263233-8903-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx>
References: <1377263233-8903-1-git-send-email-sbehrens@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)
On Fri, Aug 23, 2013 at 03:07:10PM +0200, Stefan Behrens wrote:
> Since common/config is executed twice, if SCRATCH_DEV_POOL is configured
> via the environment, the current code removes the first device entry twice
> which means that you lose the second device for the test.
> 
> The fix is to not remove anything from SCRATCH_DEV_POOL anymore.
> That used to be done (I can only guess) to allow to pass the
> SCRATCH_DEV_POOL as an argument to _scratch_mkfs. Since _scratch_mkfs adds
> the SCRATCH_DEV, the pool mustn't contain that device anymore.
> 
> A new function _scratch_pool_mkfs is introduced that does the expected
> thing.
> 

This didn't break anything and makes sense

Reviewed-by: Josef Bacik <jbacik@xxxxxxxxxxxx>

Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>