xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: v7 add the lseek() SEEK_DATA/SEEK_HOLE support

To: Mark Tinguely <tinguely@xxxxxxx>
Subject: Re: [PATCH] xfs_io: v7 add the lseek() SEEK_DATA/SEEK_HOLE support
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 23 Aug 2013 08:34:08 -0500
Cc: Rich Johnston <rjohnston@xxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <521762F4.4050603@xxxxxxx>
References: <20130822213148.224998379@xxxxxxx> <52169488.2040303@xxxxxxxxxxx> <521762F4.4050603@xxxxxxx>
On Aug 23, 2013, at 8:26 AM, Mark Tinguely <tinguely@xxxxxxx> wrote:

> On 08/22/13 17:45, Eric Sandeen wrote:
>> On 8/22/13 4:31 PM, Mark Tinguely wrote:
>> 
>>> Add the lseek SEEK_DATA/SEEK_HOLE support into xfs_io.
>>> The result from the lseek() call will be printed to the output.
>>> For example:
>>> 
>>> xfs_io>  seek -h 609k
>>> HOLE    630784
>>> 
>>> Signed-off-by: Mark Tinguely<tinguely@xxxxxxx>
>>> ---
>>>  version 7 or 8 - Eric what number is this?
>> 
>> Go for 13, for luck!
>> 
>> I think this looks ok, I won't torture you any longer.  If there's anything
>> to fix up when it really gets used in earnest we can do it then.
>> 
>> (it crossed my mind that for the "-r" and "-a" invocations it might be good 
>> to print
>> out the offset which was sent for each SEEK_* "whence," but *shrug*)
>> 
>> Thanks for all the iterations,
>> 
>> Reviewed-by: Eric Sandeen<sandeen@xxxxxxxxxx>
> 
> Rich, hold off on commit, I can quickly add the whence. We can see how she 
> sails.
> 
Was just an idle thought... See if it makes sense I guess...

Thanks,
Eric

> --Mark
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>