xfs
[Top] [All Lists]

Re: [PATCH] xfstests: btrfs/003: stat the dev we're removing to make sur

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: btrfs/003: stat the dev we're removing to make sure its' really gone
From: Josef Bacik <jbacik@xxxxxxxxxxxx>
Date: Thu, 22 Aug 2013 14:19:18 -0400
Cc: Josef Bacik <jbacik@xxxxxxxxxxxx>, <linux-btrfs@xxxxxxxxxxxxxxx>, <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fusionio.com; s=default; t=1377195560; bh=0ehJUQAxqEbW6EkuWuHRzk3UXLCYxfjKtNtmXa5eLzw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Swca27oOar2nBTb3TY7JtOLgVLIcxei78mKaHKbJbE2Uw0XPhuipq8QFHzWapC3Al SAtKLVx8+e3W8y9LlQgVjDAeTKVOU7QMIzqYDzyMvDJKyff04ozfdcqTTDTh3C5bV8 JlQDMCoHBkqfx4kIFA+3bpHac7/+tfN/RHCkFJi8=
In-reply-to: <5214EE7F.8090507@xxxxxxxxxxx>
References: <1377101015-3070-1-git-send-email-jbacik@xxxxxxxxxxxx> <5214EE7F.8090507@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2011-07-01)
On Wed, Aug 21, 2013 at 11:44:47AM -0500, Eric Sandeen wrote:
> On 8/21/13 11:03 AM, Josef Bacik wrote:
> > I've been periodically failing btrfs/003 because my box sometimes takes a 
> > little
> > longer to unregister the device when we remove it and so the output from 
> > btrfs
> > dev show doesn't match what we are wanting since it still sees the device.  
> > To
> > fix this just stat and sleep if we still see the device node and only 
> > continue
> > once udev or whatever actually removes the device node so that we don't get
> > random failures.  Thanks,
> > 
> > Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
> > ---
> >  tests/btrfs/003 |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/tests/btrfs/003 b/tests/btrfs/003
> > index 5c88651..dba1a32 100755
> > --- a/tests/btrfs/003
> > +++ b/tests/btrfs/003
> > @@ -145,6 +145,12 @@ _test_replace()
> >     _devmgt_remove ${DEVHTL}
> >     dev_removed=1
> >  
> 
> This should probably go into _devmgt_remove,
> and possibly the reverse in _devmgmt_add as well, with
> a comment explaining what it's doing?
> 
> Otherwise someone else will run into the same problem down the line.

Ok so I went to do this and realized we only send the formatted thing to the
function, ie '0 0 0' for host/target/lun or whatever the numbers line up to.  We
don't have the actual device node to check at this point, so it needs to be done
on a case by case basis.  I looked at the other tests and all they want is the
device removed for kernel stuff, which happens immediately.  We are the weird
ones checking to make sure btrfs fi show actually notices that we've removed the
device, so it's only really specific to this case and not something I can easily
add to the helper.  Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>